Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit - added support for Yarn V1 #2099

Merged
merged 34 commits into from
Aug 3, 2023
Merged

Audit - added support for Yarn V1 #2099

merged 34 commits into from
Aug 3, 2023

Conversation

eranturgeman
Copy link
Contributor

@eranturgeman eranturgeman commented Jul 26, 2023 •
edited
Loading

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

Audit command for Yarn versions lesser than 2.0.0 is now supported!
Tests and test suitcases were added and old tests got corrected accordingly

The 'audit' command in Yarn versions below 2.0.0 is now supported!
This update includes the addition of new tests and test cases, along with corrections to existing tests

depends on:
jfrog/jfrog-cli-core#878
jfrog/build-info-go#172

@eranturgeman eranturgeman marked this pull request as draft July 26, 2023 12:05
@github-actions
Copy link
Contributor

github-actions bot commented Jul 26, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Jul 26, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 26, 2023
@eranturgeman
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@eranturgeman eranturgeman temporarily deployed to frogbot July 26, 2023 13:47 — with GitHub Actions Inactive
@eranturgeman eranturgeman added safe to test Approve running integration tests on a pull request new feature Automatically generated release notes labels Jul 26, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 26, 2023
@github-actions
Copy link
Contributor

@eranturgeman eranturgeman temporarily deployed to frogbot July 27, 2023 08:25 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

@eranturgeman eranturgeman marked this pull request as ready for review July 27, 2023 12:12
@sverdlov93 sverdlov93 added the safe to test Approve running integration tests on a pull request label Jul 28, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 28, 2023
@eranturgeman eranturgeman temporarily deployed to frogbot July 30, 2023 06:21 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

@eranturgeman eranturgeman temporarily deployed to frogbot July 30, 2023 14:48 — with GitHub Actions Inactive
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Jul 30, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 30, 2023
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Aug 3, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 3, 2023
@eranturgeman eranturgeman temporarily deployed to frogbot August 3, 2023 08:56 — with GitHub Actions Inactive
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Aug 3, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 3, 2023
@eranturgeman eranturgeman temporarily deployed to frogbot August 3, 2023 11:06 — with GitHub Actions Inactive
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Aug 3, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 3, 2023
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Aug 3, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 3, 2023
@eranturgeman eranturgeman temporarily deployed to frogbot August 3, 2023 15:09 — with GitHub Actions Inactive
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Aug 3, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

@eranturgeman eranturgeman changed the title Yarn V1 Audit Audit - added support for Yarn V1 Aug 3, 2023
@eranturgeman eranturgeman merged commit 2d33908 into jfrog:dev Aug 3, 2023
56 of 59 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Aug 4, 2023
Merged
@eranturgeman eranturgeman mentioned this pull request Aug 6, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sverdlov93 sverdlov93 Awaiting requested review from sverdlov93

Assignees
No one assigned
Labels
new feature Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eranturgeman @sverdlov93